nunit / nunit/nunit-console

Agent should not try to load extensions it can't use.

Open
#760 1 comment 0 reactions 1 assignee View on GitHub

@CharliePoole is already working on this.

Since Aug 14, 2024.

Bug High Priority Needs Confirmation V4
Dominant language
C#
Stars
234
Forks
163
Avg merge
13h 32m
Merged PRs (30d)
25

Description

When we run out of process, the agent tries to find and load extensions for all possible extension points, including those that are actually in the top-level engine and can never be installed.

The reason for this is that most extensionpoints are actually defined in the API assembly, which is not divided between nunit.engine and nunit.engine.core

This issue doesn't offer an immediate solution but is a placeholder for some fix we will need to make to avoid examining all possible extension points and to cut short the evaluation of extensions to the extent possible.

Suggestions that have been made (without evealuation)

  • Split the API assembly
  • Don't define extension ponits in the API assembly
  • Implement some kind of "filtering" of extensions
  • Discover the driver extension in the engine and pass the info to the agent

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.