Improve vector FP16 comparison function
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 74
- PR merge metrics
- No merged PRs in 30d
Description
I suspect this function https://github.com/intel/x86-simd-sort/blob/7d7591cf5927e83e4a1e7c4b6f2c4dc91a97889f/src/avx512-16bit-qsort.hpp#L65 can be improved with fewer operations. See:
https://github.com/numpy/numpy/blob/0bd56e7ec12f8ceeb8d082340e71e60b873d5c57/numpy/core/src/npysort/npysort_common.h#L153 for reference.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/avx512-16bit-qsort.hpp around line 65, where the vector FP16 comparison function is located, and compare its operations with the NumPy reference in npysort_common.h around line 153. Done means preserving comparison behavior while reducing the operations used by the SIMD implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100