numpy / numpy/x86-simd-sort

check_cpu_feature_support makes repeated/unnecessary calls to std::getenv("XSS_DISABLE_AVX512")

Open Beginner friendly
#239 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1k
Forks
74
PR merge metrics
No merged PRs in 30d

Description

The result of std::getenv("XSS_DISABLE_AVX512") should be cached in lib/x86simdsort.cpp::check_cpu_feature_support .

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in lib/x86simdsort.cpp at check_cpu_feature_support and inspect how often the XSS_DISABLE_AVX512 environment lookup occurs. Done means the function reuses the environment value rather than making repeated getenv calls, with the existing project tests still passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
84/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.