Benchmarker: Add a CLI param to set N
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1k
- Forks
- 74
- PR merge metrics
- No merged PRs in 30d
Description
As today the benchmarker benchs 4 cases of partialsort:
MY_BENCHMARK_CAPTURE(func, type, k10, 10000, 10); \
MY_BENCHMARK_CAPTURE(func, type, k100, 10000, 100); \
MY_BENCHMARK_CAPTURE(func, type, k1000, 10000, 1000); \
MY_BENCHMARK_CAPTURE(func, type, k5000, 10000, 5000);
https://github.com/intel/x86-simd-sort/blob/87486d17a7d916f2992800b0219e28d0af29e765/benchmarks/bench.h#L52
For LLM inference the values are more extreme: N (vocab size) = 100000 or more, and k could be even smaller than 10.
Would you mind if I add a CLI arg to set at least N (ARRSIZE) ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with benchmarks/bench.h at the partialsort cases linked in the issue and inspect how benchmark command-line arguments are currently handled. Add a way to set ARRSIZE/N from the CLI, then verify that the partialsort benchmark can run with values such as N=100000 and small k values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, performance
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100