numpy / numpy/numtype

`timedelta64` should be a subtype of `signedinteger`

Open
#148 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

blame: NumPy numpy.generic
Dominant language
Python
Stars
79
Forks
8
PR merge metrics
No merged PRs in 30d

Description

>>> import numpy as np
>>> issubclass(np.timedelta64, np.signedinteger)
True

But this isn't reflected in stubs.

LSP-wise, it's rather sketchy, but it has to be done either way.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the stubs for the declarations of timedelta64 and signedinteger and inspect how their subtype relationships are represented. Verify that the relationship matches the runtime issubclass example and check the relevant type-checking behavior; done means the stubs expose timedelta64 as a signedinteger subtype.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.