numpy / numpy/numpydoc

Shorter section underlines trigger ambiguous validation

Open
#460 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
355
Forks
181
Avg merge
1d 9h
Merged PRs (30d)
3

Description

While testing #454 I noticed that for the following docstring,

    """Bad, bad docstring!

    Parameters
    ---------
    x : `int`
    y:
        Another variable.

    Returns
    -------
    z : `int`
        The sum of ``x`` and ``y``.
    """

which contains many issues, but the issue of the shorter underline triggers a rather misterious
PR01 | Parameters {'x', 'y'} not documented.

In fact, after adding the missing dash I get the next issues, PR01, PR02, PR07 and PR10.

From the list of available validation checks the shorter underline problem is not present, I guess because it's more an RsT issue, but since numpydoc uses RsT (unless I overlooked this), I think it should be a proper validation check.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the docstring example and reviewing the validation checks listed in the linked numpydoc validation documentation. Trace how the malformed section underline is reported, then add coverage so it is identified distinctly from parameter-documentation errors and verify the resulting validation messages.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.