numpy / numpy/numpy

Make a.diagonal() writeable.

Open
#5,407 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

17 - Task 54 - Needs decision
Dominant language
Python
Stars
32.8k
Forks
12.8k
Avg merge
1d 7h
Merged PRs (30d)
197

Description

The ndarray.diagonal method currently returns a view, but it is not writeable. It is documented to return a writeable view in 1.10.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the ndarray.diagonal implementation and its related tests. Check how the returned view's writeability is determined, compare it with the documented 1.10 behavior, and verify that assigning through the diagonal view works as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.