numpy / numpy/numpy

TST: abi3t test extension needs to be updated once meson abi3t support improves

Open
#31,587 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

05 - Testing 36 - Build 39 - free-threading
Dominant language
Python
Stars
32.8k
Forks
12.8k
Avg merge
1d 7h
Merged PRs (30d)
197

Description

Currently our test extension manually sets Py_TARGET_ABI3T because meson doesn't yet officially support abi3t and this causes issues. Once meson and meson-python gain a UI for creating abi3t extensions, we need to update our tests to use that API:

https://github.com/numpy/numpy/blob/cd490dc3d8d56c921927c7864960087802c8e17c/numpy/_core/tests/examples/limited_api/meson.build#L76

Additionally, we should remove the skips for GIL-enabled Python on Windows whenever meson adds support for the new python3t.lib and python3t.dll files in the Windows distribution.

https://github.com/numpy/numpy/blob/cd490dc3d8d56c921927c7864960087802c8e17c/numpy/_core/tests/examples/limited_api/meson.build#L69

https://github.com/numpy/numpy/blob/cd490dc3d8d56c921927c7864960087802c8e17c/numpy/_core/tests/test_limited_api.py#L106-L109

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

First verify that Meson and meson-python expose the abi3t extension API and support python3t.lib and python3t.dll on Windows. Then update numpy/_core/tests/examples/limited_api/meson.build and remove the GIL-enabled Windows skips in numpy/_core/tests/test_limited_api.py; run the limited-API tests to confirm the extension builds and passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.