Allow np.fill_diagonal to fill sub or super diagonals too
Open
Nobody has claimed this yet.
01 - Enhancement
component: numpy.lib
- Dominant language
- Python
- Stars
- 32.8k
- Forks
- 12.8k
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 197
Description
It would be really nice if np.fill_diagonal could fill other diagonals besides the main diagonal. This would match the offset argument of np.diagonal.
Shouldn't require much code to allow this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the np.fill_diagonal entry point and compare its behavior with the offset argument of np.diagonal. Review the existing fill_diagonal coverage before deciding how sub- and super-diagonal offsets should behave. Done means supported offsets fill the corresponding diagonals consistently with np.diagonal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100