nstudio / nstudio/nativescript-plugins
exoplayer: player.mute() does nothing
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 55
- Forks
- 42
- Avg merge
- 49m
- Merged PRs (30d)
- 1
Description
Calling videoPlayer.mute(true) does nothing.
Dived a little into the source code and found that the mute functionality is commented out
mute(mute) {
/* if (this.mediaPlayer) {
if (mute === true) {
this.mediaPlayer.setVolume(0);
} else if (mute === false) {
this.mediaPlayer.setVolume(1);
}
}*/
}
I uncommented it in my node_modules directory and debugged, this.mediaPlayer is always null, so in effect still does nothing.
If I change it to:
mute(mute) {
this.player.setVolume(mute ? 0 : 1);
}
it seems to mute and unmute fine.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ExoPlayer plugin's mute(mute) method shown in the issue and trace how the player instance is initialized. Verify mute and unmute operate on the live player rather than the null mediaPlayer reference, then reproduce the Android behavior to confirm both volume changes work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100