nspcc-dev / nspcc-dev/neofs-node

Clean up code for writing service messages

Open
#4,005 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement I4 S3 U4
Dominant language
Go
Stars
38
Forks
51
Avg merge
1d 20h
Merged PRs (30d)
38

Description

why all these func are in the service/object? why not somewhere in iprotobuf lib?

Originally posted by @carpawell in https://github.com/nspcc-dev/neofs-node/pull/3996#discussion_r3319877041

make a lib with reusable generic code. Likely it will go to SDK. In particular, https://pkg.go.dev/github.com/nspcc-dev/neofs-sdk-go@v1.0.0-rc.19/client pkg definitely needs it

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the service/object package and the iprotobuf-related code referenced in the issue, then compare the needs of the neofs-sdk-go client package. Identify which service-message functions are generic and determine their appropriate reusable SDK location. Done means the shared code is no longer unnecessarily tied to service/object and the affected client usage remains covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, distributed-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.