nspcc-dev / nspcc-dev/neofs-node

Store metabase object counters in a single KV pair

Open
#3,893 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement I4 neofs-storage S3 U3
Dominant language
Go
Stars
38
Forks
51
Avg merge
1d 20h
Merged PRs (30d)
38

Description

Is your feature request related to a problem? Please describe.

I'm always frustrated when metabase work nonoptimal.

Describe the solution you'd like

Counters are stored in a single KV pair as a usual concatenation of 8-byte counters. Usually, they are updated in a single transaction one by one.

Describe alternatives you've considered

Keep it as is.

Additional context

Originally posted by @roman-khimov in https://github.com/nspcc-dev/neofs-node/pull/3856#discussion_r2952198711

I am not sure if it is worth it, to be honest. Also, it is not clear whether we need it if https://github.com/nspcc-dev/neofs-node/pull/3856#discussion_r2952776563 is not solved, cause this is the fastest possible optimization we can do, but it is not done yet. Some benchmarking would be appreciated.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by reviewing the discussion in pull request 3856 and benchmark the current counter updates against the proposed single-KV-pair representation; done means the approach is justified by measurements and the counters are stored and updated consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.