nspcc-dev / nspcc-dev/neofs-node

Use synctest in long time-dependent tests

Open
#3,857 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement I4 S2 test U4
Dominant language
Go
Stars
38
Forks
51
Avg merge
1d 20h
Merged PRs (30d)
38

Description

Is your feature request related to a problem? Please describe.

I'm always frustrated when unit tests take a lot of time to complete.

Describe the solution you'd like

Identify tests that run too long because of async processes and waiting for them (shard/engine/etc). We don't need to convert all tests, only ones that are problematic (10s+ to run). Convert these tests to synctest package available since Go 1.25.

Describe alternatives you've considered

Things work as is.

Additional context

https://github.com/nspcc-dev/neofs-node/issues/3525
https://pkg.go.dev/testing/synctest
https://github.com/nspcc-dev/dbft/pull/157/changes/e944d6910338b9ef6fed7c90dbfc91f2a3c5b924

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No specific files or tests are named. Start by locating tests that take 10 seconds or more because they wait on asynchronous shard or engine processes, then read the Go 1.25 testing/synctest documentation and linked examples. Done means the selected long-running tests use synctest and complete reliably in less time.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.