nspcc-dev / nspcc-dev/neofs-node

Do not treat expirations as engine-level thing for regular objects

Open
#3,524 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement I3 neofs-storage S2 U3
Dominant language
Go
Stars
38
Forks
51
Avg merge
1d 20h
Merged PRs (30d)
38

Description

Is your feature request related to a problem? Please describe.

I'm always frustrated when I realize that we're doing things we can avoid.

Describe the solution you'd like

Simple object expiration can be final at the shard level. Split objects do require some passing to engine level since we need to release all associated children, but simple objects are simple. The only thing that can prevent their expiration is lock. Locks should always be put into shards that have respective objects (they're associated). What can prevent this from happening is shard being RO in which case lock should be put into some available shard, but marked for subsequent move (RO shard doesn't delete objects anyway). Local state can then be leveraged to mark previously degraded shards and deal with moves before starting the GC (but after a shard becoming RW).

Describe alternatives you've considered

Some things can be discussed here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating the expiration, shard, lock, and GC flows, then determine how simple and split objects are distinguished. Done means simple-object expiration is finalized at the shard level while split objects retain the required engine-level coordination and deferred moves from read-only shards.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.