nspcc-dev / nspcc-dev/neofs-node

Provide option to bypass CLI-side checks

Open
#3,183 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement I3 neofs-cli S3 U4
Dominant language
Go
Stars
38
Forks
51
Avg merge
1d 20h
Merged PRs (30d)
38

Description

Is your feature request related to a problem? Please describe.

I'm always frustrated when i cannot skip internal CLI checks which do not allow to pack and send the request to NeoFS. Although pre-checks are mostly for good, sometimes they do not allow to communicate with the system. Currently, this can only be fixed by CLI upgrading

i propose to add ability to send requests no matter what. Plus bonus in test coverage performed by @evgeniiz321: make sure that SNs also check request conditions

Describe the solution you'd like

provide -f, --force flag cancelling all internal checks when user input can be packed into a structurally valid request message

we already use such practice for some cmds, e.g.:

$ neofs-cli container create -h
  -f, --force                 Skip placement validity check

Additional context

https://github.com/nspcc-dev/neofs-testcases/issues/652#issuecomment-2689124735

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the existing neofs-cli container create --force behavior and trace where CLI checks run before requests are packed. Review how Storage Nodes validate request conditions and the related test coverage mentioned in the issue. Done means structurally valid requests can be sent with -f, --force, while invalid request structure is still rejected and Storage Node checks are covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.