nspcc-dev / nspcc-dev/neofs-node

Do not call main chain as `mainnet`

Open
#3,052 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

config enhancement I2 S3 U4
Dominant language
Go
Stars
38
Forks
51
Avg merge
1d 20h
Merged PRs (30d)
38

Description

NeoFS runs above two chains - main and FS ones. And there is a public NeoFS network - NeoFS Mainnet. Sometimes main chain-related stuff is called mainnet. Like here https://github.com/nspcc-dev/neofs-node/blob/474d5413f894149457526057584d2f52133e06f7/config/example/ir.yaml#L99

this is legit for NeoFS Mainnet itself, but confuses me in general

i propose to call main chain as main chain (mainchain where appropriate) everywhere where it is not NeoFS Mainnet itself that is meant (like https://github.com/nspcc-dev/neofs-node/tree/master/config/mainnet). With this, there will be main and FS chains pair instead of mainnet and FS chain

old configs must keep working ofc

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with config/example/ir.yaml and the config/mainnet directory, then inspect repository occurrences of mainnet to distinguish the NeoFS Mainnet network from the main chain. Done means terminology consistently uses main chain or mainchain where appropriate, while NeoFS Mainnet naming and compatibility with old configs remain intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
blockchain, distributed-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.