nspcc-dev / nspcc-dev/neofs-node

Control API passes addresses in stringified format

Open
#2,980 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement I4 neofs-storage S3 U4
Dominant language
Go
Stars
38
Forks
51
Avg merge
1d 20h
Merged PRs (30d)
38

Description

Is your feature request related to a problem? Please describe.

I'm always frustrated when I realize we have to parse addresses in control API just because we have string representations being used in the protocol.

Describe the solution you'd like

Use good old bytes, it's protobuf anyway. 32 for OID. 32 for CID. 64 for address.

Describe alternatives you've considered

Keeping as is, it works with some slight overhead.

Additional context

#2968

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the control API protobuf definitions and the context in #2968, then trace how OID, CID, and address fields are currently represented and parsed. Done means the control API uses byte fields with the requested sizes and its affected callers and protocol behavior remain consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.