nspcc-dev / nspcc-dev/neofs-node

Improve GC routine

Open
#2,866 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement I4 S2 U3
Dominant language
Go
Stars
38
Forks
51
Avg merge
1d 20h
Merged PRs (30d)
38

Description

Is your feature request related to a problem? Please describe.

GC may be more intelligent. Currently, it only works with clear wording like "a user deleted an object" or "epoch N happened, so every object whose expiration is <= N-1 should expire too". But sometimes real garbage may appear in the storages (bad migration, shard error, bugs, configuration changes, missed meta change notification etc), and some background routine may try to monitor it.

Describe the solution you'd like

If some object without a container, lost object part, or some other object that should not exist is found, it should be GC-ed. A background routine fits well for this.

Describe alternatives you've considered

Some explicit external command like vacuum in the control service.

Additional context

https://github.com/nspcc-dev/neofs-node/issues/2858 happened and there is a fix for it :https://github.com/nspcc-dev/neofs-node/pull/2863. However, it does not solve the problem fully: if some parts are stored and no parent header is found, it will never be GC-ed now.
It should be solved carefully. Situations, when a node believes that there is no object in the network, should be proved.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the current GC implementation and the context in issue #2858 and pull request #2863. Define how a background routine identifies orphaned objects or parts and proves that no object exists in the network before reclaiming storage; completion requires handling missing containers and parent headers without deleting valid data.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.