nspcc-dev / nspcc-dev/neofs-node
Do not ignore errors ever
Open
Nobody has claimed this yet.
enhancement
I4
neofs-adm
neofs-cli
neofs-lancet
S4
U4
- Dominant language
- Go
- Stars
- 38
- Forks
- 51
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 38
Description
Expected Behavior
Never ignore errors in gonang.
Current Behavior
Code may ignore some errors (even if they are not expected at all, that is not good).
Possible Solution
Panic if an error is not expected at all.
Context
At least CLIs are affected: binding flags, getting flags, marking flags.
Some other places may be affected too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with cmd/neofs-cli/modules/root.go, cmd/neofs-lens/root.go, and cmd/neofs-lens/internal/flags.go, focusing on the linked flag operations. Review the surrounding error handling and identify other affected locations. Done means unexpected errors are no longer silently ignored in the affected CLI paths and the relevant tests or CLI checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100