nspcc-dev / nspcc-dev/neofs-node
Do not log same errors in policer twice
Open
Nobody has claimed this yet.
enhancement
I3
neofs-storage
S2
U3
- Dominant language
- Go
- Stars
- 38
- Forks
- 51
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 38
Description
Do not log same errors in policer twice. Seems useless, if we cannot select any nodes from the container, it won't change during this epoch.
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.922Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.922Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
окт 26 10:32:18 buky neofs-node[24920]: 2022-10-26T10:32:18.923Z error policer/check.go:98 could not build placement vector for object {"component": "Object Policer", "cid": "ChimApoDVi9nYhiQohTKrVhYMvNsVuTiXMcJCr4RNyt", "error": "could not get container nodes: not enough nodes to SELECT from: ''"}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in policer/check.go at the logged failure around line 98 and trace how objects are processed during an epoch. Confirm how repeated placement-vector errors are produced and define the change so identical errors are not logged repeatedly within one epoch; done means the duplicated log entries shown in the issue are suppressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems, observability-sre
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100