nspcc-dev / nspcc-dev/neofs-node
`neofs-adm` waits for potentially useless transactions
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 38
- Forks
- 51
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 38
Description
It is common practice to send some TXs, cache their hashes, and wait for their chain inclusion.
Adm CLI stops if one of the TX has not been persisted but does not stop if one of the TX was failed. Moreover, we return only the first not-HALT-err and drop other errors.
I suggest just stopping iterating on any non-HALT TX. It also would simplify the code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in cmd/neofs-adm/internal/modules/morph/initialize.go at the transaction-waiting logic around lines 334-380. Trace how failed transactions and non-HALT errors are handled, then verify that iteration stops for any non-HALT transaction and that relevant errors are retained; run the neofs-adm test suite if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- blockchain, cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100