nspcc-dev / nspcc-dev/neofs-node

Place signing funcitonality in `core/crypto` package

Open
#1,387 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement I4 S2 U4
Dominant language
Go
Stars
38
Forks
51
Avg merge
1d 20h
Merged PRs (30d)
38

Description

I propose to gather all crypto-related things in core/crypto package which will be a mediator between app packages and neofscrypto package from NeoFS SDK Go. See places in code which are tagged with the current issue.

We need to also provide well-known errors from crypto package: missing signature, invalid signature, etc.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the code locations tagged with issue #1387 and the existing crypto usage across app packages. Compare those call sites with the NeoFS SDK Go neofscrypto package and the proposed core/crypto boundary. Done means crypto-related access is gathered behind core/crypto and the package exposes well-known errors for missing and invalid signatures.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cryptography, distributed-systems
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.