nspcc-dev / nspcc-dev/neofs-dev-env

Actualize wallets

Open
#267 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

discussion documentation help wanted I4 S3 U4
Dominant language
Makefile
Stars
10
Forks
25
PR merge metrics
No merged PRs in 30d

Description

As I understand we have some copypasted accounts for years (https://github.com/nspcc-dev/neofs-dev-env/blob/9e092f3f8e0b27d4cbf67aaf53137f61ccb276b6/services/chain/node-wallet.json#L23-L48? multi-sig? what? @roman-khimov, @AnnaShaleva).

Also, some of them have labels while some do not. I would expect a perfect repo with wallets to be fully labeled. Wallet naming also bothers me (node-wallet.json (what wallet? neo-go? neofs-node?)/wallet.json).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare services/chain/node-wallet.json and services/morph_chain/node-wallet.json, then inspect other wallet.json and node-wallet.json files in the repository. Start by determining which wallets are required and whether labels and filenames have an established convention. Done means the wallet files are intentionally named and consistently labeled, with obsolete copies clarified or removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
blockchain, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.