nspcc-dev / nspcc-dev/neofs-dev-env

Remove symlink after `prepare storage` target

Open
#109 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug I3 S4 U4
Dominant language
Makefile
Stars
10
Forks
25
PR merge metrics
No merged PRs in 30d

Description

After #92 we have prepare.storage target that creates storage node's TLS certificate symlink to the host machine. However it never removed. make clean target removes storage node's certificate but it didn't affect symlink. It solves the issue technically, but it would be better if we will keep clean host machine.

Possible options:

  • do not create symlink at prepare.storage target, but show ln -s command for the user to manage it on it's own (kinda like we propose to modify /etc/hosts file and do not modify it in the scripts,
  • remove symlink at make clean target.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Makefile targets named prepare.storage and clean, then inspect how the certificate symlink is created and how the storage certificate is removed. Resolve which of the two proposed cleanup approaches fits the project’s existing conventions, and verify that running make clean leaves the host machine without the unwanted symlink.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.