nspcc-dev / nspcc-dev/neofs-api

Expand session token statuses

Open
#289 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature I2 S2 U4
Dominant language
Makefile
Stars
11
Forks
15
Avg merge
2d 8h
Merged PRs (30d)
9

Description

Is your feature request related to a problem? Please describe.

I'm always frustrated when I see regular problems but cannot assign some well-known status to them. Session token is a good well-structed candidate. We did it once: https://github.com/nspcc-dev/neofs-api/issues/191. Now we also have validation on the SN side and now such errors can be seen by a user: https://github.com/nspcc-dev/neofs-node/pull/2731, https://github.com/nspcc-dev/neofs-node/pull/2727.

Describe the solution you'd like

Possible status codes:

  1. Wrong token issuer/not signed by container owner
  2. Invalid signature
  3. Wrong session operation
  4. Wrong container

Describe alternatives you've considered

Not sure all of them (or any of them) are required and having a separate code for them can make user's life easier but for the tests a well structured response for such an important NeoFS part may look pretty.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing neofs-api issue #191 and the linked neofs-node pull requests #2731 and #2727 to understand the existing session-token validation and status handling. Resolve which proposed statuses are required and define the API changes and tests needed for a structured response.

Written by the indexing model from the issue text.

Assessment

Domain
api, authentication
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.