nrwl / nrwl/empty-template

Potential bugs?

Open
#5 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
5
Forks
5
Avg merge
3d 2h
Merged PRs (30d)
1

Description

I notice some unexpected behavior in newly created workspaces...

  • In nx.json file, the namedInputs.sharedGlobals is now an empty array instead contains the "{workspaceRoot}/.github/workflows/ci.yml" path. Creating a new ci workflow using @nx/workspace generators, adds the workflow path to the sharedGlobals, so I think there is a bug of the empty template
  • The template uses @org/source instead of the name of the workspace, this is intentional?
  • The GitHub workflow use rpm even when the workspace was created using --pm=pnpm flag

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing nx.json and .github/workflows/ci.yml in this template with output from the @nx/workspace generators for a pnpm workspace. Check the sharedGlobals entry, the @org/source placeholder, and the package-manager commands; done means each discrepancy is either corrected or confirmed as intentional.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, javascript
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.