nrepl / nrepl/weasel

Doesn't work with recent clojurescript; goog.net.WebSocket constructor changed

Open
#76 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
323
Forks
31
PR merge metrics
No merged PRs in 30d

Description

src/cljs/weasel/impls/websocket.cljs:23 needs to wrap its arguments in an object, per https://google.github.io/closure-library/api/goog.net.WebSocket.html. Currently the code TypeError's on ClojureScript 1.10.773.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/cljs/weasel/impls/websocket.cljs:23 and compare its constructor call with the goog.net.WebSocket API documentation, using the ClojureScript 1.10.773 behavior as the reproduction context. Done means the WebSocket constructor no longer throws a TypeError with recent ClojureScript.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.