nprapps / nprapps/dailygraphics-next

Some apostrophes don't get converted into correct smart quotes

Open
#66 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
72
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Specifically working in Best TV/Films, but probably true everywhere; links when the show is at the beginning of the line (e.g. <a href="[link">'[show title]'</a>) or when the quote follows a symbol. Apostrophes in Google Sheets aren't converted to &lsquo; in HTML. (Applies to the opening quote — the closing quote is converted correctly)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reproducing the Best TV/Films case with a show at the beginning of a line and with a quote after a symbol, then trace the smart-quote conversion and HTML output. Done means opening apostrophes become ‘ in these cases while closing quotes remain correctly converted.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.