Fixed the CI failures — ready for re-review! 🙏
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.1k
- Forks
- 4.7k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 19
Description
Fixed the CI failures — ready for re-review! 🙏
The starttag override was accidentally a module-level function instead of an HTML5Translator method (bare super() + missing return), which is what ruff/mypy/pyright/ty were flagging. It is now a proper method override matching the docutils signature, always delegating to super().starttag(). Also dropped a redundant condition in i18n.py.
Verified locally: ruff clean on all touched lines, plus test_intl (61), test_build_html and test_config (123) all pass.
Originally posted by @hesam-oxe in https://github.com/sphinx-doc/sphinx/pull/14429#issuecomment-5661678071
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced Sphinx pull request and inspect the HTML5Translator entry point and i18n.py. Review the reported test_intl, test_build_html, and test_config results; the work is done when the stated static checks and tests pass in the referenced change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100