[BUG] *.domain.tld not recognized in NO_PROXY env
Open
Nobody has claimed this yet.
Enhancement
- Dominant language
- JavaScript
- Stars
- 10.1k
- Forks
- 4.7k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 19
Description
Is there an existing issue for this?
- I have searched the existing issues
This issue exists in the latest npm version
- I am using the latest npm
Current Behavior
Currently, only .domain.tld is interpreted in NO_PROXY, wildcard *.domain.tld seem to be handled as actual char.
Expected Behavior
*.domain.tld should match all subdomains.
This should be standardized according to: https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/#standardizing-no_proxy
Steps To Reproduce
- Have
HTTPS_PROXYandHTTP_PROXYset to a proxy (yourproxy.tld) andNO_PROXY="*.domain.tld"to reach a registry. - Run
npx http-server - See error...
Environment
- npm: v8.15.0 (LTS, but same for latest)
- Node.js: v16.17.0 (LTS, but same for latest)
- OS Name: Windows 10
- npm config:
registry=https://server.domain.tld/nexus/repository/npm/
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the behavior with HTTPS_PROXY, HTTP_PROXY, NO_PROXY="*.domain.tld", and the npx http-server entry point on Windows. Trace npm CLI's proxy and NO_PROXY handling, then locate its existing tests or implementation; done means wildcard subdomains match without breaking the existing .domain.tld behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- cli, networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100