npm / npm/cli

feature(arborist) build-ideal-tree should maybe disregard the package-lock for nodes that have been changed in package.json

Open
#4,281 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement ws:arborist
Dominant language
JavaScript
Stars
10.1k
Forks
4.7k
Avg merge
2d 2h
Merged PRs (30d)
19

Description

currently we read the full package-lock.json, then attempt to place the modifications in the package.json (or the explicit changes the user requested) on top of it, which is potentially yielding more work than is necessary. if we disregard these locked nodes and jump straight to adding the new ones, we should be able to build the ideal tree more quickly and resolve more peer conflicts than we do today.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Arborist's build-ideal-tree entry point and trace how package-lock.json is applied over package.json changes. Compare the handling of locked nodes with explicitly changed nodes, then verify that the ideal tree builds with less unnecessary work and resolves more peer conflicts.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
cli, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.