npm / npm/cli

[but] npm audit fix downgrades with pre-1.0.0 semver

Open
#3,708 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Priority 2 Release 7.x
Dominant language
JavaScript
Stars
10.1k
Forks
4.7k
Avg merge
2d 2h
Merged PRs (30d)
19

Description

Is there an existing issue for this?
  • I have searched the existing issues
Current Behavior
# npm audit report

glob-parent  <5.1.2
Severity: moderate
Regular expression denial of service - https://npmjs.com/advisories/1751
fix available via `npm audit fix --force`
Will install htmlhint@0.9.9, which is a breaking change
node_modules/glob-base/node_modules/glob-parent
  glob-base  *
  Depends on vulnerable versions of glob-parent
  node_modules/glob-base
    parse-glob  >=2.1.0
    Depends on vulnerable versions of glob-base
    node_modules/parse-glob
      htmlhint  >=0.9.10
      Depends on vulnerable versions of parse-glob
      node_modules/htmlhint

4 moderate severity vulnerabilities

after audit fix --force I get 6 high severity vulnerabilities instead of the original 4 moderate... so much for fix...

Expected Behavior

No downgrade

Steps To Reproduce

htmlhint": "^0.15.1

run npm audit

Environment
  • OS: win10
  • Node: v14.17.3
  • npm: 7.20.5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the report with htmlhint ^0.15.1 on Node v14.17.3 and npm 7.20.5, then run npm audit followed by npm audit fix --force. Compare the resulting dependency versions and vulnerability counts. Done means the forced fix does not downgrade htmlhint or increase the reported vulnerabilities.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
cli, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.