notepad-plus-plus / notepad-plus-plus/notepad-plus-plus

For R-to-L languages, text that appears highlighted sometimes isn't the text that's actually highlighted

Open
#8,093 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
29.4k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Description of the Issue

If I highlight a portion of the text and press the delete/backspace button, the part that's deleted isn't the text that I highlighted (and which appears highlighted).

Steps to Reproduce the Issue
  1. Paste the following text into a new editor:
    הרצליה: 074-6665001 | test1@test1.com
    חיפה: 074-6665000 | test2@test2.com
    תל אביב: 074-6665002 | test3@test3.com

  2. Highlight the "650" on any line

  3. Type something, or press delete, or press backspace

  4. Note that the replaced/deleted text is not the text that had been highlighted.

Expected Behavior

The replaced/deleted text is the text that had been highlighted.

Actual Behavior

For the purposes of the action above (replace/delete), the R-to-L language characters are considered to be in a different order than as displayed. Therefore, the replaced/deleted text is not necessarily the text that had been highlighted.

Debug Information

Notepad++ v7.8.5 (32-bit)
Build time : Mar 4 2020 - 11:04:20
Path : C:\Program Files (x86)\Notepad++\notepad++.exe
Admin mode : OFF
Local Conf mode : OFF
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 1909
OS Build : 18363.720
Plugins : mimeTools.dll NppConverter.dll NppExport.dll

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the selection and delete/backspace behavior in the Notepad++ editor using the supplied Hebrew and numeric sample. Test highlighting "650" on each line and replacing or deleting it. Done means the text replaced or deleted is exactly the text that appears highlighted.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop, internationalization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.