notepad-plus-plus / notepad-plus-plus/notepad-plus-plus
NPPN_FILECLOSED not being send
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 29.4k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Description of the Issue
NPPN_FILECLOSED message is not send to Plugins for closing a tab under following condition:
- The tab is the last one in the View (main view or sub view)
- The tab’s buffer has not been changed
- The tab’s buffer is not associated to a file
The NPPN_FILEBEFORECLOSE message works correctly.
Expected Behavior
The NPPN_FILECLOSED message should be send each time you close a tab.
Debug Information
Notepad++ v7.4.2 (32-bit)
Build time : Jun 18 2017 - 23:34:19
Path : C:\Program Files (x86)\Notepad++\notepad++.exe
Admin mode : OFF
Local Conf mode : OFF
OS : Windows 10 (64-bit)
Plugins : ComparePlugin.dll HexEditor.dll mimeTools.dll NppConverter.dll NppExport.dll PluginManager.dll
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace tab-closing behavior for the last unchanged, untitled tab in the main or sub view, focusing on the NPPN_FILEBEFORECLOSE and NPPN_FILECLOSED plugin notifications. Verify that closing any tab sends NPPN_FILECLOSED to plugins, including when its buffer is not associated with a file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api, desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100