notepad-plus-plus / notepad-plus-plus/notepad-plus-plus

hitting SaveAs on an open file continuously loops through open files if you hit cancel

Open
#13,783 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
29.4k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Description of the Issue

When you have an open file which has been previously saved, and hit 'Save As', it opens the Save As dialog (normal). Then if you hit Cancel, the 'SaveAs' dialog opens again with different file names as you continue to hit "Cancel". You cannot close the dialog without it coming back, so you have to save the file as something to get out of the loop.

Steps to Reproduce the Issue
  1. Open a file in Notepad++ which has previously been saved, or save it as a file.
  2. With the file still open, press the Save As button. A Save As dialog appears.
  3. Press 'Cancel' on the Save As dialog.
  4. SaveAs will keep popping up as you hit Cancel. You have to save the file to get it to stop.
Expected Behavior

Save As dialog should go away after Cancel is pressed.

Actual Behavior

Save As dialog keeps re-appearing when 'Cancel' is pressed, you have to actually save the file.

Debug Information

Notepad++ v8.5.3 (32-bit)
Build time : May 15 2023 - 06:07:16
Path : C:\Program Files (x86)\Notepad++\notepad++.exe
Command Line : "C:\Program Files (x86)\Notepad++\change.log"
Admin mode : OFF
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 22H2
OS Build : 19045.2965
Current ANSI codepage : 1252
Plugins :
mimeTools (2.9)
NppConverter (4.5)
NppExport (0.4)
NPPJSONViewer (1.34)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Save As and Cancel sequence described in the issue on Windows, then trace the Save As command and dialog-cancel handling. Done means Cancel closes the dialog without reopening it or cycling through filenames, while saving still works normally.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.