notepad-plus-plus / notepad-plus-plus/notepad-plus-plus

DirectWrite not showing hardcoded fonts of theme xml

Open
#12,393 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
29.4k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Hello,

I've created a theme that uses some hardcoded font name formatting (because it uses font weights other than just Regular and Bold).
Hardcoded font faces

If I turn on DirectWrite to make use of ligatures, it messes up the syntax elements with these font faces.
DirectWrite setting

Correct display without DirectWrite:
DirectWrite off

Messed up hardcoded font face with DirectWrite:
DirectWrite on

If I have to choose between hardcoded font usage and ligatures, I'd go with the former, but I wouldn't be happy to give up ligatures either.

Thanks.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with DirectWrite enabled using a theme XML that specifies hardcoded font faces and compare it with DirectWrite disabled. Trace the DirectWrite rendering path and theme font handling; done means custom font faces render correctly while ligatures remain available.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.