notepad-plus-plus / notepad-plus-plus/notepad-plus-plus

Bookmark and hidden-lines margin symbols can overlap to bad visual effect

Open
#12,178 19 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
29.4k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Description of the Issue

Bookmark and hidden lines margin marker symbols, when occurring on the same line, can overlap such that the effect is not good:

image

Mentioned first here: https://github.com/notepad-plus-plus/notepad-plus-plus/pull/12165#issuecomment-1245918299

Steps to Reproduce the Issue

Bookmark a line and then "strategically" hide some lines such that the closing hide line margin symbol and the bookmark marker symbol appear on the same line.

Expected Behavior

Well, something not so overlapping. :-)

Serious suggestion: Since it has never worked well and consistently, don't attempt to do margin marker symbols for hidden lines -- have another method for user making hidden lines visible again (the only function of the margin marker symbols). These margin markers aren't necessary to alert the user to where hidden lines are, because the green line drawn across the editing area does this. Of course, this implies that an alternative method for making hidden lines visible is created (not sure what that would be at the moment).

Actual Behavior

Overlap.

Debug Information

Notepad++ v8.4.5 (32-bit)
Build time : Sep 3 2022 - 03:56:37
Path : C:\...\npp.8.4.5.portable\notepad++.exe
Command Line : -titleAdd="8.4.5 32-bit" -multiInst
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 21H2
OS Build : 19044.1889
Current ANSI codepage : 1252
Plugins :
mimeTools (2.8)
NppConverter (4.4)
NppExport (0.4)
PythonScript (3.0.12)

@Yaron10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the overlap by bookmarking a line and strategically hiding lines until the closing hide-line symbol shares its margin with the bookmark marker. Read the discussion linked from PR #12165, then define completion as a margin presentation that no longer overlaps while preserving a way to reveal hidden lines.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.