notepad-plus-plus / notepad-plus-plus/notepad-plus-plus

Removing all shortcuts from a Scintilla command is confusing

Open
#12,040 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
29.4k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Description of the Issue

It is confusing for a user to obtain the correct method for removing all keycombos for a Scintilla command using Shortcut Mapper.

Steps to Reproduce the Issue
  1. Assign 2 keycombos to a Scintilla command that previously had no keycombos assigned, obtaining this:
    image
  2. User desire is to now return the command to having no keycombos assigned; user intuitively presses the Remove button to obtain:
    image
  3. User is now surprised to see that with the remaining keycombo selected, the Remove button is disabled!
Expected Behavior

Whenever there is 1 or more keycombos assigned, the Remove button should be enabled.

Actual Behavior

Remove button is disabled and user has to resort to the unintuitive method of picking None from the dropdown and clicking Apply to get the last remaining keycombo removed. Even a user's instinct of clicking OK (without first doing Apply) will NOT get the final keycombo removed (after choosing None).

Debug Information

Notepad++ v8.4.4 (64-bit)
Build time : Jul 15 2022 - 17:54:42
Path : C:\...\npp.8.4.4.portable.x64\notepad++.exe
Command Line : -titleAdd="8.4.4 64-bit" -multiInst "C:\...\npp.8.4.4.portable.x64\license.txt"
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 21H2
OS Build : 19044.1826
Current ANSI codepage : 1252
Plugins :
mimeTools (2.8)
NppConverter (4.4)
NppExport (0.4)
PythonScript (2)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Shortcut Mapper Remove, Apply, and None controls and their enabled-state logic; the payload names no file or test. Done when Remove remains enabled with one or more key combinations assigned and removes the final combination, with the reported steps verified on Windows.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.