notepad-plus-plus / notepad-plus-plus/notepad-plus-plus
Enhancement: Support more than 9 keywords lists for lexers
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 29.4k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Description of the enhancement
In current code, getKwClassFromName (in Paramters.cpp) is hardcoded to only allow 9 keywords lists to be configured for lexers. The code comment suggests that it was due to the limitation defined as KEYWORDSET_MAX, which was 8 in the past, but was increased to 30 back in 2012, so it seems possible to allow more keywords lists to be defined if the hardcoded handling can be changed to be based on KEYWORDSET_MAX. For example, allow name to be userDefinedXX where XX starts from 1 and be capped at (KEYWORDSET_MAX + 1) - 9? Or allow typeXX to go beyond 7 and cap it at (KEYWORDSET_MAX + 1) - 2?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Paramters.cpp at getKwClassFromName and trace how lexer keyword-list names are mapped and limited. Compare that handling with KEYWORDSET_MAX, then define and verify support for additional keyword-list names while preserving the existing limits and behavior for current names.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100