notepad-plus-plus / notepad-plus-plus/notepad-plus-plus
[Makefile] multiline comments aren't highlighted correctly
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 29.4k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Description of the Issue
According to GNU Make Manual:
"‘#’ in a line of a makefile starts a comment. It and the rest of the line are ignored,
except that a trailing backslash not escaped by another backslash will continue the
comment across multiple lines."
Steps to Reproduce the Issue
- Create new file
- Change syntax to Makefile
- Type lines shown on the screenshot
Expected Behavior
The expected behaviour is, that in the second paragraph (on the screenshot), the second line should be treated as a continuation of a comment.
Actual Behavior
Debug Information
Notepad++ v8.1.4 (64-bit)
Build time : Aug 21 2021 - 13:04:59
Path : C:\Program Files\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 8.1 Pro (64-bit)
OS Build : 9600.20094
Current ANSI codepage : 1250
Plugins : mimeTools.dll NppConverter.dll NppExport.dll
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is identified in the issue. Start by reproducing the Makefile syntax-highlighting case in Notepad++ v8.1.4 and inspect the Makefile lexer entry point; done means a comment continued with an unescaped trailing backslash highlights through the following line.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100