notationlabs / notationlabs/notation
envs as config
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 54
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
NOTATION_STATE_PATH feels like a code smell for a few reasons:
- pass through config to state providers
- config in env – prefer via config file if using cli, or passed in explicitly if using programatic api
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing where NOTATION_STATE_PATH is read and how state providers receive configuration. Compare the CLI config-file path with the programmatic API's explicit configuration path, then confirm that both no longer depend on the environment variable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nodejs, typescript
- Domain
- api, cli
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100