notationlabs / notationlabs/notation
Refreshing deployment state fails – no resource key
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 54
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Currently refresh fails when trying to delete a resource. This is because when the resource object is constructed from remote state, it does not have the key of the resource.
To resolve, the resources remote state needs to be read into the resource objects output.
Relevant bit: https://github.com/notationhq/notation/blob/main/packages/core/src/provisioner/workflows/workflow.refresh.ts#L25-L32
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/core/src/provisioner/workflows/workflow.refresh.ts at lines 25-32 and trace how remote state is turned into resource objects. Confirm that the resource key is preserved for deletion, then verify that refreshing state no longer fails when deleting a resource.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100