RDN string spacing
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Is it correct to add extra whitespace here around the equals sign? (Probably, but...)
https://github.com/nonebot/nonecorn/blob/nonecorn_dev/src/hypercorn/utils.py#L277
Inserting whitespace is not advised because it may not be obvious to the user which whitespace is part of the DN string and which whitespace was added for readability.
From: https://www.rfc-editor.org/rfc/rfc4514
At least for consistency I'd argue to have a similar representation as the PEM format produced by OpenSSL, which does not have (extra) spaces around equals sign (checked on v1.1.1n).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/hypercorn/utils.py line 277 and compare its RDN formatting with the RFC 4514 guidance linked in the issue and OpenSSL's PEM output. Confirm the intended whitespace convention with the project before changing anything; done means the representation follows the accepted convention and any relevant coverage reflects it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100