nofusscomputing / nofusscomputing/centurion_ui
Remove workaround in NotificationDrawer unit test
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 20
Description
Details
As PatternFly doesn't (as v6.5.0) does not officially support React 19. A workaround had to be added to a unit test so it functions correctly.
Links
- Source Commit -> d4c6b0a3dde7b135f9c232bf68fed04bc3b165d5
- #209
Tasks
- Remove workaround
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/components/test/unit/NotificationDrawer.test.js at lines 256-276 and review source commit d4c6b0a3dde7b135f9c232bf68fed04bc3b165d5 to understand the workaround. Remove the workaround once PatternFly supports React 19, then run the NotificationDrawer unit test to confirm it still passes without it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend, testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 75/100