spec doesn't finalize connection on network error
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 7.7k
- Forks
- 880
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 68
Description
I've been reading through the spec a few times now and there seems to be missing a connection cleanup somewhere.
The problem is that whenever we replace response with a network error (example) that means that we no longer will read that response nor do we close the associated connection. Effectively leaking the connection.
Is this a bug in the spec or am I missing something? Maybe we need a "terminate" in fetch finale?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/fetch/index.js around line 503 and trace how a response becomes a network error during fetch finale. Compare that flow with the spec's connection-lifecycle requirements and determine where cleanup is expected. Done means the network-error path no longer leaves the associated connection unfinalized.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100