Try to avoid accessing `Request.aborted` in `Client`
Open
@ronag is already working on this.
Since Aug 30, 2020.
enhancement
- Dominant language
- JavaScript
- Stars
- 7.7k
- Forks
- 880
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 68
Description
Accessing Request.aborted should not be needed.
- Remove unnecessary check before
request.onUpgrade. - Remove unnecessary check after
request.onConnect. - Find a more elegant solution for killing socket when head of pipeline is aborted.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.