Client will connect even if all requests are aborted
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 7.7k
- Forks
- 880
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 68
Description
Client will not notice requests might be aborted until request.onConnect which will only happen after the socket has connected. Thus the client might unnecessarily create a connection if all pending requests have been aborted.
A bit of an edge case.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the client request lifecycle around request.onConnect and the handling of pending requests that have been aborted. Confirm when connection creation is triggered, then verify that no unnecessary connection is created when all pending requests are aborted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100