Move logic to interceptors
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- JavaScript
- Stars
- 7.7k
- Forks
- 880
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 68
Description
Once https://github.com/nodejs/undici/pull/2826 lands we can start moving some logic into interceptors in order to ensure we get similar logic for all api implementations:
- throwOnError as interceptor
- dump as interceptor
- signal handling as interceptor
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing nodejs/undici#2826 and the interceptor implementations used by the API implementations. Scope the work around moving throwOnError, dump, and signal handling into interceptors, then verify that all API implementations receive the same behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, backend, networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100