nodejs / nodejs/undici

redirect handler is broken

Open
#2,837 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
7.7k
Forks
880
Avg merge
2d 16h
Merged PRs (30d)
68

Description

Will unexpctedly call `onConnect´ on sub handlers which causes weird undefined problems.

Refs: https://github.com/nodejs/undici/pull/2285

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the redirect handler and read the behavior described in the issue, then use the referenced pull request #2285 for context. Determine why sub-handlers receive onConnect unexpectedly; done means redirects no longer trigger the reported undefined problems.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.