Improve tests with more checks for unexpected `'disconnect'`
Open
Nobody has claimed this yet.
enhancement
good first issue
- Dominant language
- JavaScript
- Stars
- 7.7k
- Forks
- 880
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 68
Description
Some of our tests might emit disconnect, reconnect and then pass even though a disconnect was not expected.
Add more assertions (t.fail()) to catch this if it happens.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the repository's tests that can emit disconnect and reconnect events; the issue does not identify a specific file or test. Add t.fail() checks where an unexpected disconnect should fail, then run the relevant test suite and confirm that unexpected disconnects no longer pass silently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100